docs: add CLAUDE.md and REVIEW.md for Claude Code integration#82
Closed
coryyeakelacdc wants to merge 11 commits intoShopify:mainfrom
Closed
docs: add CLAUDE.md and REVIEW.md for Claude Code integration#82coryyeakelacdc wants to merge 11 commits intoShopify:mainfrom
coryyeakelacdc wants to merge 11 commits intoShopify:mainfrom
Conversation
Copied from Shopify Horizon commit a6a3484ce86dea3810290bad9c475847ba504c86 Skeleton base commit 04069e0 Copied: - 94 blocks, 52 sections, 116 assets, 95 snippets - Templates, config, locales, layout (Horizon replacements) - Dual license attribution (LICENSE-SKELETON.md, LICENSE-HORIZON.md) - Architecture and execution plans (.planning/) - Source provenance (HORIZON_VERSION.md) Zero modifications - vanilla copy for v1.0.0.
11 original Skeleton sections were unreferenced by any template and caused 31 theme check errors due to missing locale keys (Horizon's locales replaced Skeleton's). All have Horizon equivalents that templates already use. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- package.json: @acadaca-shopify/acadaca-core-theme@1.0.0 with GitHub Packages registry - README.md: replaced Skeleton's with agency core theme docs - CONTRIBUTING.md: replaced Skeleton's with agency dev workflow - CHANGELOG.md: v1.0.0 release notes with source provenance - PRUNING_STRATEGY.md: block usage tracking and annual review process - .gitignore: added *.tgz Tested: npm pack (938kB, 421 files) -> test install -> shopify theme check passes with same 2 upstream Horizon errors as source. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
chore: add npm package configuration and documentation
Publishes to GitHub Packages on version tag push (v*). Uses built-in GITHUB_TOKEN for authentication. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
These were inherited from the Shopify/skeleton-theme fork and require Shopify-specific secrets (CLA_TOKEN) and permissions that don't exist in our org. Removes merge blockers on PRs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ci: add automated npm publish workflow
Prevents accidental commit of npm auth tokens. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Documents what belongs in core vs client repos, contribution workflow, versioning rules, publishing process, upstream tracking strategy, and how client updates work. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
docs: add CORE.md development guide
CLAUDE.md provides project context, commands, architecture decisions, and conventions for Claude Code sessions. REVIEW.md is a comprehensive code review guide covering Liquid, JS, CSS, accessibility, performance, SEO, and security for Shopify theme development.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
REVIEW-local.mdfor store-specific rules.Test plan